Good morning. I just recently purchased a Mavic 2 pro. I started  with the controller that came with the Mavic 2 pro. I then purchased a smart controller.  I activated the smart controller and started taking video and photos. My problem that I'm having is that some times the videos and photoes do not show up in my albums

You should find all your pictures on the SD card,  or if your connected with a controller press the play button in the bottom right and you can copy the files back to your phone/controller.

Perhaps it’s saving to your internal storage